Repository navigation
ci(playwright): detect hogql-parser changes with the paths filter - #125835
Conversation
|
😎 Merged successfully - details. |
🤖 CI report
|
HostHog preview —
|
|
Risk: No findings CI-only change: replaces the per-run master fetch + git diff that gated rebuilding the hogql-parser in the Playwright workflow with a Sentinel reviewed |
There was a problem hiding this comment.
Approved.
The CI change is disclosed and has owning-team authorship plus a current-head review reporting no findings. No unresolved substantive concerns or other refusal grounds were found.
- Author wrote 0% of the modified lines and has 89 merged PRs in these paths (familiarity MODERATE).
- PostHog Review (Standard) reviewed the current head: no findings.
Gate mechanics and policy version
| Gate | Result | |
|---|---|---|
| prerequisites | ✓ | all clear |
| deny-list | ✓ | no deny categories matched |
| size | ✓ | 20L, 1F substantive — within ceiling |
| tier | ✓ | T1-agent / T1a-trivial (20L, 1F, single-area, ci) |
| stamphog 2.6.1 | .stamphog/policy.yml @ 8ad8ad8 · reviewed head 8ad8ad8 |
webjunkie
left a comment
There was a problem hiding this comment.
🤖 Agent review · steered by a person
Problem
Changes
The
changesjob now decides whether to build the parser.flowchart LR A[changes<br/>paths filter] --> B[playwright<br/>fetch master, git diff] --> C[build parser<br/>if changed] class A,C phBlue; class B phRed; classDef phBlue fill:#1d4aff,stroke:#1d4aff,color:#fff; classDef phRed fill:#f54e00,stroke:#f54e00,color:#fff;flowchart LR A[changes<br/>paths filter + hogqlParser] --> C[playwright<br/>build parser if changed] class A,C phBlue; classDef phBlue fill:#1d4aff,stroke:#1d4aff,color:#fff;pulls.listFilescall answers a newhogqlParserfilter. No new token.How did you test this code?
hogqlParser = false, build skipped.Test rationale: Not needed. The stubbed plan covers the changed condition.
Release status
Docs update
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Agent: Claude Code, claude-opus-5-5
Skills:
/authoring-ci-workflows,/writing-pr-descriptions,/writing-code-commentsMore context for AI agents
.depot/workflows/ci-backend.ymlstephogql-parser-difffetches master and diffscommon/hogql_parser/andrust/hogql/parser/the same way.hogql-parserpin inpyproject.toml. Comparing thesetup.pyversion with the pin would catch it.shouldRunfilter does not listcommon/hogql_parser/**, so a parser-only PR skips E2E.if:of "Install the working version of hogql-parser".